Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: add store membership to the liveness record #137545

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewbaptist
Copy link
Collaborator

This commit only changes the protobuf, it does not explicitly use the field anywhere.

Epic: none

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andrewbaptist andrewbaptist force-pushed the 2024-12-16-add-store-membership branch from 86890a9 to ef06b78 Compare December 17, 2024 14:26
This commit only changes the protobuf, it does not explicitly use the
field anywhere. Since the protobuf now includes a map, it is necessary
to use `Equal` rather than == to compare the liveness record to the
empty one.

Epic: none

Release note: None
@andrewbaptist andrewbaptist force-pushed the 2024-12-16-add-store-membership branch from ef06b78 to dc3316f Compare December 17, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants